Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar autoclose on small screens #225

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Sidebar autoclose on small screens #225

merged 5 commits into from
Jan 19, 2022

Conversation

titkov49
Copy link
Contributor

No description provided.

@titkov49
Copy link
Contributor Author

Screen.Recording.2022-01-17.at.10.27.03.mov

@titkov49 titkov49 marked this pull request as ready for review January 17, 2022 09:30
Pe5h4
Pe5h4 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@Pe5h4 Pe5h4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just implement that grayish foreground for a main container when sidebar is open on small screens and overlaps the content of the container. It should also disable clicking on the main container as we spoke of on standup

@titkov49
Copy link
Contributor Author

@Pe5h4 this is it, right?

Screen.Recording.2022-01-17.at.11.36.59.mov

@Pe5h4
Copy link
Collaborator

Pe5h4 commented Jan 17, 2022

@titkov49 yep

@Pe5h4 this is it, right?
Screen.Recording.2022-01-17.at.11.36.59.mov

@ateska
Copy link
Contributor

ateska commented Jan 17, 2022

Looks cool.

@titkov49 titkov49 merged commit f1b695e into master Jan 19, 2022
@titkov49 titkov49 deleted the feature/sidebar-autoclose branch January 19, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ateska ateska ateska approved these changes

@Pe5h4 Pe5h4 Pe5h4 approved these changes

@petrKavulok petrKavulok Awaiting requested review from petrKavulok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titkov49 @Pe5h4 @ateska