Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move about module below to the bottom of the sidebar #183

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Move about module below to the bottom of the sidebar #183

merged 3 commits into from
Oct 12, 2021

Conversation

titkov49
Copy link
Contributor

No description provided.

@titkov49
Copy link
Contributor Author

Screenshot 2021-10-12 at 10 43 39

Screenshot 2021-10-12 at 10 43 45

Screenshot 2021-10-12 at 10 43 51

@titkov49 titkov49 requested review from Pe5h4 and ateska October 12, 2021 09:56
@titkov49
Copy link
Contributor Author

@ateska @Pe5h4 review please :)

ateska
ateska requested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@ateska ateska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks fine ... but it should be left aligned.

Pe5h4
Pe5h4 requested changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@Pe5h4 Pe5h4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you add the changes into changelog please?

src/containers/Sidebar/index.js Outdated
unauthorizedNavItems = props.unauthorizedNavItem,
unauthorizedNavChildren= props.unauthorizedNavChildren;
unauthorizedNavChildren= props.unauthorizedNavChildren,
aboutItem = props.navigation.getItems().items.find(item => item.name === "About");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@titkov49 find will not work on older browser versions and definitely not on internet explorer (I now its obsolete, but some companies/people still uses that). It might be better to use filter instead.

@titkov49
Copy link
Contributor Author

Screenshot 2021-10-12 at 23 06 37

Screenshot 2021-10-12 at 23 06 42

Screenshot 2021-10-12 at 23 06 48

Screenshot 2021-10-12 at 23 06 53

@titkov49
Copy link
Contributor Author

Changes:

  1. Edit changelog
  2. Align text in sidebar item to left
  3. Use Array.prototype.filter instead of Array.prototype.find

@titkov49 titkov49 merged commit 7a28889 into master Oct 12, 2021
@titkov49 titkov49 deleted the feature/sidebar-move-about-below branch October 12, 2021 21:12
@ateska
Copy link
Contributor

ateska commented Oct 13, 2021

  1. Can the background color be the same as for other items in the left bar
  2. colapse/expand button should be full (not ouline) to improve its visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ateska ateska ateska requested changes

@Pe5h4 Pe5h4 Pe5h4 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titkov49 @ateska @Pe5h4