Change reply scripting command to player color
#1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a small visual fix to an inconsistency with textbox colors in simplified scripting. The `reply` command is meant to be used for the player, and always correctly positions it above the player, while the `say` command may be used to generate a cyan textbox that's positioned above a cyan non-player crewmate. However, the color for both textboxes is always `cyan`, so the `reply` command doesn't use the (normally identical) `player` color even though all its other behavior (squeak, position) does. Now that customized textbox colors were added in 2.4 (TerryCavanagh#910), it's a shame that this distinction isn't made between `cyan` and `player`, so this change addresses that (before we're stuck with levels that change `cyan` but not `player`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This is just a small visual fix to an inconsistency with textbox colors in simplified scripting. The
replycommand is meant to be used for the player, and always correctly positions it above the player, while thesaycommand may be used to generate a cyan textbox that's positioned above a cyan non-player crewmate. However, the color for both textboxes is alwayscyan, so thereplycommand doesn't use the (normally identical)playercolor even though all its other behavior (squeak, position) does. Now that customized textbox colors were added in 2.4 (#910), it's a shame that this distinction isn't made betweencyanandplayer, so this change addresses that (before we're stuck with levels that changecyanbut notplayer).As discussed with @InfoTeddy, this should be fine to include in a 2.4.2.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement