Make language screen show up once more #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that two new variants of Spanish have been added, it would be a shame that many players from Latin-America/Argentina may stay on Castilian or English because they don't realize the new versions were added for them. So now, if you've set your language in 2.4.0, the language screen will show up once more in 2.4.1. This is done by simply incrementing the lang_set flag to 2 - so that if it's 0 or 1, your language setting is considered to be possibly outdated. This shouldn't inconvenience players who don't need to select a new language - their existing language will still be pre-selected, so they can just hit ACTION once. Terry confirms he did the same thing with Dicey Dungeons and says it's a good idea (and that nobody minds).
After some discussion about the previous commit, the usecase of managing tons of basedirs and locking files in the filesystem might mean it gets annoying to have the language screen show up again whenever a new language is added, for a small group of people. The solution to get the best of both worlds is to only re-ask for the language in the default basedir. This means barely anyone will miss their language having been newly added (especially since barely anyone will use any custom basedirs, let alone ONLY custom ones).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Now that two new variants of Spanish have been added, it would be a shame that many players from Latin-America/Argentina may stay on Castilian or English because they don't realize the new versions were added for them. So now, if you've set your language in 2.4.0, the language screen will show up once more in 2.4.1. This is done by simply incrementing the lang_set flag to 2 - so that if it's 0 or 1, your language setting is considered to be possibly outdated.
This shouldn't inconvenience players who don't need to select a new language - their existing language will still be pre-selected, so they can just hit ACTION once.
Terry confirms he did the same thing with Dicey Dungeons and says it's a good idea (and that nobody minds).
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement