Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small fixes to Arabic, Spanish LATAM and Spanish AR #1148

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

Daaaav
Copy link
Contributor

@Daaaav Daaaav commented Feb 5, 2024

Changes:

  • Fix placeholders in Arabic strings_plural
    For some reason all of us overlooked that all of them were {n_crew}, even those which required a different placeholder key... https://steamcommunity.com/sharedfiles/filedetails/?id=3154670529

  • Change LATAM Spanish meta.xml Oprime to Pulsa
    All of them were changed except for the one in meta.xml. I think it's safe to assume this is correct, because everywhere else, the same "Oprime {button} para" pattern always became "Pulsa {button} para" too.

  • Align dimensional stability generator in Spanish LATAM and Spanish AR

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes unless there is a prior written agreement

For some reason all of us overlooked that all of them were {n_crew},
even those which required a different placeholder key...

https://steamcommunity.com/sharedfiles/filedetails/?id=3154670529
All of them were changed except for the one in meta.xml. I think it's
safe to assume this is correct, because everywhere else, the same
"Oprime {button} para" pattern always became "Pulsa {button} para" too.
@InfoTeddy InfoTeddy added the localization Implies 'required for 2.4' unless otherwise noted label Feb 5, 2024
@InfoTeddy InfoTeddy merged commit 929aaeb into TerryCavanagh:master Feb 6, 2024
@Daaaav Daaaav deleted the lang-file-maint-2024-02-05 branch February 8, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Implies 'required for 2.4' unless otherwise noted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants