Add a one pixel gap between each line in textboxes #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfoTeddy
added
the
localization
level complete, game complete and "You have rescued a crew member!"
TerryCavanagh
force-pushed
the
linegap
branch
from
bdcf31c to
22f49db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This change adds a one pixel gap between each line in textboxes, though only in the main game for now. It addresses this issue: #1051
A few screenshots of how it looks:
So! There was a lot of discussion about whether or not this change was a good idea on the discord, which is very fair - it does change the look of the game pretty noticeably, and it breaks the C64 8x8 grid. I found myself going back and forth on it a little bit - so I figured the best thing to do was just to try it, and make it a bit less hypothetical. I'll distribute a compiled version on the discord for easy testing.
Now that I've done it, I really like it! I actually find it quite jarring to go back to the zero gap textboxes in custom levels:
What do you think?
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes