Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to action sets #834

Open
leo60228 opened this issue Sep 1, 2021 · 3 comments
Open

Switch to action sets #834

leo60228 opened this issue Sep 1, 2021 · 3 comments
Labels
localization Implies 'required for 2.4' unless otherwise noted

Comments

@leo60228
Copy link
Contributor

leo60228 commented Sep 1, 2021

This was already mentioned in #829, but I thought it was deserving of its own issue, especially since it:

This might have to wait for libsdl-org/SDL#4464.
@AllyTally AllyTally mentioned this issue Sep 1, 2021
Open
@flibitijibibo
Copy link
Collaborator

Hypothetically we can do this without SDL_ActionSet, but it is absolutely 100% worth the effort to try and develop this in SDL first. I would read everything in the proposal, including all the links and videos, to get a sense of how it would work. Steam Input's native API would probably be our starting template.

@flibitijibibo flibitijibibo mentioned this issue Sep 13, 2021
Closed
@InfoTeddy InfoTeddy mentioned this issue Oct 12, 2021
Open
@flibitijibibo flibitijibibo added the localization Implies 'required for 2.4' unless otherwise noted label Jan 18, 2022
This was referenced Jan 18, 2022
Closed
Closed
@flibitijibibo
Copy link
Collaborator

flibitijibibo commented Jan 18, 2022 •
edited
Loading

Going to scope this down slightly:

While we don't have the SDL interface yet, we can still prepare for it by fixing the way input is bound and read. We need to rework the input as follows:

We'll have to wire in the key/button events ourselves for now. When we rewire our input layer to SDL_ActionSet it will resolve the issue described in #759.

@flibitijibibo flibitijibibo removed the SDL label Jan 18, 2022
@flibitijibibo flibitijibibo mentioned this issue Jan 18, 2022
Closed
@flibitijibibo flibitijibibo mentioned this issue Feb 11, 2022
Closed
4 tasks
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 8, 2023
@Daaaav
Add support for button glyph display
e0e998c 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 8, 2023
@Daaaav
Add support for button glyph display
ba1a9ea 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
@Daaaav Daaaav mentioned this issue Mar 8, 2023
Merged
2 tasks
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 10, 2023
@Daaaav
Add support for button glyph display
67fa972 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 17, 2023
@Daaaav
Add support for button glyph display
0b66ac9 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 20, 2023
@Daaaav
Add support for button glyph display
aaf006f 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 21, 2023
@Daaaav
Add support for button glyph display
9d03ab6 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 21, 2023
@Daaaav
Add support for button glyph display
6f3cb49 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
Daaaav added a commit to Daaaav/VVVVVV that referenced this issue Mar 22, 2023
@Daaaav
Add support for button glyph display
a75f291 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in TerryCavanagh#834 (Jan 18, 2022).
InfoTeddy pushed a commit that referenced this issue Mar 22, 2023
@Daaaav @InfoTeddy
Add support for button glyph display
3354a1a 
This adds a function that converts an action (such as interacting
in-game) to the corresponding button text ("ENTER", "E") or button
glyph (PlayStation triangle, Steam Deck Y, etc). This function
currently only gives the existing ENTERs or Es, because I don't know
how best to detect controller usage, or whether the game is running on
a Steam Deck, or what buttons need to be displayed there. Still, it
should now be really easy to adapt the rendering of keyboard keys to
consoles, controllers, or rebound keys.

To identify the actions that currently need to be displayed, this
commit also adds the initial enums for action sets as described by
Ethan in a comment in #834 (Jan 18, 2022).
@AllyTally AllyTally mentioned this issue May 18, 2023
Open
8 tasks
@flibitijibibo
Copy link
Collaborator

This got delayed due to ActionSet's ongoing development, and the fact that it will be in SDL3 which is still in develolpment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
localization Implies 'required for 2.4' unless otherwise noted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flibitijibibo @leo60228 @InfoTeddy