-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack5 comments #7450
base: webpack5
Are you sure you want to change the base?
Webpack5 comments #7450
Conversation
@@ -136,9 +136,6 @@ | |||
|
|||
.btn--back-to-my-data { | |||
composes: btn from "../../../../Sass/common/_buttons.scss"; | |||
// TODO: fix? | |||
// composes: btn-small from "../../../../Sass/common/_buttons.scss"; | |||
// composes: btn--left from "../../../../Sass/common/_buttons.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btn--left
was an icon definition so it is safe to remove
btn-small
wouldn't make any point here as we have all its styles defined/overriden here or in styled-component
@@ -36,15 +36,6 @@ $btn-setting-size: 35px; | |||
margin: 0; | |||
} | |||
|
|||
// TODO: fix? | |||
// .btn-small { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used anywhere anymore
What this PR does
Test me
Locally:
Checklist
doc/
.