Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack5 comments #7450

Open
wants to merge 11 commits into
base: webpack5
Choose a base branch
from
Open

Conversation

zoran995
Copy link
Collaborator

What this PR does

Test me

Locally:

  • sync terriamap-terriajs dependencies
  • install dependencies
  • run the project
  • check that everything works the same (type checking is still working, assimpjs works correctly (copy-plugin-webpack))

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

package.json Show resolved Hide resolved
@zoran995 zoran995 mentioned this pull request Jan 29, 2025
7 tasks
@@ -136,9 +136,6 @@

.btn--back-to-my-data {
composes: btn from "../../../../Sass/common/_buttons.scss";
// TODO: fix?
// composes: btn-small from "../../../../Sass/common/_buttons.scss";
// composes: btn--left from "../../../../Sass/common/_buttons.scss";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btn--left was an icon definition so it is safe to remove
btn-small wouldn't make any point here as we have all its styles defined/overriden here or in styled-component

@@ -36,15 +36,6 @@ $btn-setting-size: 35px;
margin: 0;
}

// TODO: fix?
// .btn-small {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anywhere anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants