Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoRssConvertor: add missing return statement #7429

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

What this PR does

Adds a missing (?) return statement. If the intention is to return undefined when falling out of the loop, the result variable is unused and should be removed.

Test me

Not sure how to test this.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@@ -157,6 +157,7 @@ function getGeometryFromWhere(node) {
result = getGeometryFromWhere(child);
}
}
return result;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoran995 this code is from 2020 in commit 8ebc61a, do you remember if your intention was to return undefined when falling out of the loop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoran995 seems I pinged you in the middle of the holidays so not sure if you saw this, do you have any recollection of whether the fall-through in this function (but not the others) was intentional?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't recall anymore; it seems like a forgotten. Why else would someone create an object and return it? Ideally, we need to find a sample, test it and make sure it works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants