test: fix BottomDockChart parameters + disable failing test #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component seems to expect height and width.
Re-disable this test and restore the old FIXME comment. The problem might be something else, but at least that gives an idea about what the initial problem was.
pjonsson
force-pushed
the
test-fix-parameters
branch
from
640a4c5 to
3f19d0a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The BottomDockChart contains height and width properties, so change the name of the parameters to match that.
Fixing the parameter names also causes the test to fail, so disable the test and restore the old comment about why it was failing.
Test me
Test only changes.
Checklist
doc/.