Remove deprecated transformer code #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Best to remove this dead code to avoid unnecessary classloading
Just to be safe
ACGaming
merged commit 535ff35
into
TerraFirmaCraft-The-Final-Frontier:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mod refactor seems to have gone well, so it should be safe to remove the old transformer code that I marked as deprecated in 2.1.0. It seems to be best practice to avoid referencing any MC classes to avoid unnecessary classloading (which may interfere with other transformers depending on load order), so removed the no longer used code.
Also moves the logger back to its own class like before, just to be safe with classloading.