-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable backspace for mobile platform. #70
base: master
Are you sure you want to change the base?
Conversation
181d079
to
4c09ec9
Compare
I think it's bad idea to totally reject key stroke. It made many functional keybinding not usable. Just accept it as PC does and throw those situation to application developer is more resonable.
4c09ec9
to
7fc229f
Compare
What soft keyboard do you use? Different soft keyboards behave quite differently. Some keyboards I tested never generate keyboard events thus it's necessary to do some hack to listen for backspace events. It will be nice if you can provide more information about your use case(for example: os, keyboard, IME ...) so I can make further investigation. |
Yes, you're right. In my emulator, keyboards never generate keyboard events so I have set acceptKeyboardStorke to true. However, It made Enter send twice.So I removed onTextEdit. Last day night, I have test on my android phone, It seems some problem after delete onTextEdit. It make input failed, So I add it back. so, The problem is:
hoppfully helpful |
My android phone is Xiaomi 10 Lite, base on Android 11. |
14895a1
to
c7ba8be
Compare
I wish my experience is of any use, and that this is the right place to share it. I'm going to describe why I agree with the pull request and how I managed its consequences inside my android app. The app I'm writing resembles the pty example. On android 11 crDroid rom, AOSP keyboard works in any case, but:
If I do not check for the key and unconditionally return KeyEventResult.handled, Digit keys do not work on any keyboard, not even AOSP; and on bluetooth keyboard, all letters do not work. Thank you for your memorable work |
I think it's bad idea to totally reject key stroke. It made many functional keybinding not
usable. Just accept it as PC does and throw those situation to
application developer is more resonable.