Add optional read acknowledge #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARM works cmatrix -r in high speed is problematic (maybe the ack mechanism is needed again) composing state input doesn't work
this is handy to avoid the read thread reading stuff faster than the processing can process it
|
The windows implementation is currently missing |
|
added Windows implementation as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional acknowledge mechanism that allows the consumer of the pty data to signal that it has finished processing it.
This way it is prevented that the pty process is sending data faster than the consumer is able to process.
An example of this happening is if e.g.
cmatrix -ris run and set to full speed (pressing0)