Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a way to just login without using XMPP #163

Open
Luc1412 opened this issue May 22, 2022 · 1 comment
Open

Offer a way to just login without using XMPP #163

Luc1412 opened this issue May 22, 2022 · 1 comment
Labels
enhancement New feature or request v4.0

Comments

@Luc1412
Copy link
Contributor

Luc1412 commented May 22, 2022

Reason:

Save memory and bandwidth when using fortnitepy to just fetch some data.

Implementation:

Similar to Discord.py a connect() and login() method can be useful. Connect connects to XMPP, Login just handles authorization.

.start() and .run() will execute both.

Terbau added a commit that referenced this issue Jul 28, 2022
Adds a stripped down client named BasicClient. This client can only perform basic http requests. Client now inherits from BasicClient.

#163
@Terbau
Copy link
Owner

Terbau commented Jul 29, 2022

I was originally against this as it seemed too complicated and would only further confuse users of the library, but after thinking about it for some time I arrived at a solution I feel fits this library. Instead of having to mess around with methods, you can choose to use either BasicClient or Client.

I have only tested that basic functionality works in both. I'm yet to test all methods, but since I might be gone for a few days I decided to push the commit so others can test it if they want. I will also get around to creating an example for the usage of this new client.

I will leave this issue open until both clients have been tested properly.

@Terbau Terbau added enhancement New feature or request v4.0 labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4.0
Projects
None yet
Development

No branches or pull requests

2 participants