Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): color for disabled state #2234

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Sep 4, 2024

Description

Fixing the disabled state for the outlined text field and area components

What's included?

Test Steps

  • npm run storybook
  • then navigate to the text field and area stories
  • finally turn on the disabled control to see the state change and the theme switcher button at the top

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Broken

Screenshot 2024-09-04 at 1 31 28 PM

Fixed

Screenshot 2024-09-04 at 2 00 45 PM

@vicalcantFrontEnd
Copy link
Collaborator

@owilliams320 LGTM!

@owilliams320 owilliams320 merged commit 179b78f into main Sep 4, 2024
7 checks passed
@owilliams320 owilliams320 deleted the fix/components-disabled-text-field branch September 4, 2024 18:13
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 8.20.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants