Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notebook-cell): add a slot for drag handle #2233

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Aug 29, 2024

Description

  • With the current implementation, drag logic will be applied to the entire cell. This is causing issues with text selection, or scrolling of outputs.
  • In order to prevent the entire cell component from being dragged, add a slot for drag handle where users can pass any component. They can add the drag logic to this slot.

What's included?

  • Add a slot called drag-handle in the notebook cell component
  • Update notebook cell story

Test Steps

  • npm run storybook
  • Open notebook cell story
  • Make sure drag handle is rendered correctly

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-08-29 at 3 28 16 PM

@bsahitya bsahitya merged commit afea4ba into main Aug 29, 2024
7 checks passed
@bsahitya bsahitya deleted the fix/cell-drag-handle branch August 29, 2024 20:38
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.20.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants