Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add delay to app shell navigation hover #2186

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

owilliams320
Copy link
Collaborator

Description

Adding delayed opening when hovering over app shell navigation

What's included?

  • Including a 250ms delay when user now hovers over the app shell when in collapsed mode
  • Added same delay for closing app-shell which is also configurable

Test Steps

  • npm run storybook
  • then navigate to the app-shell story
  • finally test the app shell navigation that is delays properly

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

@owilliams320 owilliams320 merged commit a9463d2 into main Jul 23, 2024
7 checks passed
@owilliams320 owilliams320 deleted the feat/app-shell-delay branch July 23, 2024 15:18
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 8.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

bsahitya pushed a commit that referenced this pull request Jul 29, 2024
bsahitya pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants