Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): app shell update #2067

Merged
merged 27 commits into from
Nov 1, 2023
Merged

feat(components): app shell update #2067

merged 27 commits into from
Nov 1, 2023

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Oct 27, 2023

Description

Component App shell UX updates

What's included?

  • Adding a current section name property to app shell
  • BREAKING: removing the list item expansion component and moving that functionality to nav-list-item component
  • SCSS import fix for library to enable styles import into scss file from npm package
  • fix for icons not using default icon font 'Material Symbols Outlined'

Test Steps

  • nx serve components
  • then wait for the browser to open
  • finally test the app shell view according to the new UX specs

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

Screenshot 2023-10-30 at 12 50 36 PM
Screenshot 2023-10-30 at 12 50 05 PM

@owilliams320 owilliams320 changed the title Feat/app shell update feat(app) shell update Oct 27, 2023
@owilliams320 owilliams320 changed the title feat(app) shell update feat(app): shell update Oct 27, 2023
@owilliams320 owilliams320 changed the title feat(app): shell update feat(components): app shell update Oct 30, 2023
@owilliams320 owilliams320 merged commit 87c4686 into main Nov 1, 2023
@owilliams320 owilliams320 deleted the feat/app-shell-update branch November 1, 2023 21:15
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants