Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade VectorizationBase #15

Merged
merged 4 commits into from
Sep 8, 2021
Merged

upgrade VectorizationBase #15

merged 4 commits into from
Sep 8, 2021

Conversation

GiggleLiu
Copy link
Member

@GiggleLiu GiggleLiu commented Sep 8, 2021

@chriselrod I am trying to upgrade VectorizationBase to v0.21. In order to see the place that it errors, I removed several lines about stridedpointer first. It magically not show any error.

Can you please help me check whether I am doing it correctly?

@GiggleLiu
Copy link
Member Author

Wait... The tests take more than 3 hours and is still running, I have to kill it:
image

Why is it so slow? I didn't see the same issue on my local host.

@chriselrod
Copy link
Collaborator

Why is it so slow? I didn't see the same issue on my local host.

Did tests pass locally?
If so, I'd let it keep going. Maybe reduce the number of tests.

CI takes many times longer when it's getting code coverage info.

src/gemm.jl Outdated Show resolved Hide resolved
@GiggleLiu
Copy link
Member Author

GiggleLiu commented Sep 8, 2021

Why is it so slow? I didn't see the same issue on my local host.

Did tests pass locally?
If so, I'd let it keep going. Maybe reduce the number of tests.

CI takes many times longer when it's getting code coverage info.

Yes. It is not about the number of tests, it is mainly about the first several tests. The compiling is very slow. The test on my local host takes less than 3min. I do not think taking 3 hour is normal.

@chriselrod
Copy link
Collaborator

chriselrod commented Sep 8, 2021

Yes. It is not about the number of tests, it is mainly about the first several tests. The compiling is very slow. The test on my local host takes less than 3min. I do not think taking 3 hour is normal.

Same basic story with Octavian's and LoopVectorization's tests.
I think the slow down you describe is a bit extreme, even compared to those libraries, but sadly it is not exactly unexpected.

@GiggleLiu
Copy link
Member Author

Just removed the coverage from CI. It works! thanks for your hint~

@GiggleLiu GiggleLiu merged commit a0dc908 into master Sep 8, 2021
@chriselrod
Copy link
Collaborator

You could try something like Octavian does:
https://github.com/JuliaLinearAlgebra/Octavian.jl/blob/ead8fbb53d55fa726d135a7b83af099acec57093/.github/workflows/ci.yml#L14-L58
It has a "test" and "coverage" job.

Then it checks if code coverage is enabled before running the slowest tests. Something like that may help.

It'd let you test a bunch of different sizes (if that's a concern), while still getting a code coverage (under)estimate from some smaller / faster subset of tests.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants