-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade VectorizationBase #15
Conversation
Did tests pass locally? CI takes many times longer when it's getting code coverage info. |
Yes. It is not about the number of tests, it is mainly about the first several tests. The compiling is very slow. The test on my local host takes less than 3min. I do not think taking 3 hour is normal. |
Same basic story with Octavian's and LoopVectorization's tests. |
Just removed the coverage from CI. It works! thanks for your hint~ |
You could try something like Octavian does: Then it checks if code coverage is enabled before running the slowest tests. Something like that may help. It'd let you test a bunch of different sizes (if that's a concern), while still getting a code coverage (under)estimate from some smaller / faster subset of tests. |
@chriselrod I am trying to upgrade VectorizationBase to v0.21. In order to see the place that it errors, I removed several lines about
stridedpointer
first. It magically not show any error.Can you please help me check whether I am doing it correctly?