Fix max zoom warning behavior #24
Merged
2samueld merged 4 commits intoTengda-He:bfs7.7.1from Nov 4, 2021
Merged
Conversation
Tengda-He
approved these changes
Nov 3, 2021
2samueld
changed the title
zhyuanqi
approved these changes
Nov 4, 2021
Tengda-He
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue: When map is zoomed in to the max level, a pop up warning is displayed. However after the warning is clicked and closed by the functional test, it again zooms in consequently triggering the warning. Since this functional test checks for the warning to be closed, the functional test fails.
Solution: this PR removes the code that zooms in again/redundantly.
Image of tile map zoomed in with warning showing up:
NOTE: The tile map has been updated and this test case has been removed in the future PR: elastic#105326