Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TENDERLY_ prefix to env variable. #183

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add TENDERLY_ prefix to env variable. #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tenderly-hardhat/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ In order to successfully verify a proxy contract, please read the chapters about
This will lead you to setup the configuration the right way, so you can verify your proxy contracts and their implementation on Tenderly.

After you have successfully configured `hardhat.config.ts`, you need to populate the configuration in the format that `@nomicfoundation/hardhat-verify` plugin expects, given that this plugin uses their verification beneath for verifying proxies.
But luckily, we have provided a way to automatically populate the configuration for you, you just need to set the `AUTOMATIC_POPULATE_HARDHAT_VERIFY_CONFIG=true` environment variable.
But luckily, we have provided a way to automatically populate the configuration for you, you just need to set the `TENDERLY_AUTOMATIC_POPULATE_HARDHAT_VERIFY_CONFIG=true` environment variable.

In order to see how this all plays out, you can clone our [@tenderly/hardhat-tenderly](https://github.com/Tenderly/hardhat-tenderly) repo and navigate to the [examples/contract-verification](https://github.com/Tenderly/hardhat-tenderly/tree/master/examples/contract-verification) directory.
This directory contains all the possibilities that you can explore in order to verify your proxy contracts.
Expand Down
25 changes: 17 additions & 8 deletions packages/tenderly-hardhat/src/tenderly/extender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,8 @@ export function setup() {
extendHardhatDeploy(hre);
logger.debug("Wrapping ethers library finished.");
}
// If the user has selected automatic population of hardhat-verify `etherscan` configuration, and it in fact is some of the Tenderly networks.
// We should populate the configuration.
if (
process.env.AUTOMATIC_POPULATE_HARDHAT_VERIFY_CONFIG === "true" &&
(isTenderlyNetworkConfig(hre.network.config) ||
isTenderlyGatewayNetworkConfig(hre.network.config)) &&
isHttpNetworkConfig(hre.network.config)
) {

if (shouldPopulateHardhatVerifyConfig(hre)) {
logger.info(
"Automatic population of hardhat-verify `etherscan` configuration is enabled.",
);
Expand Down Expand Up @@ -230,6 +224,21 @@ const extendUpgrades = (hre: HardhatRuntimeEnvironment): void => {
}
};

// Returns true if the user has selected automatic population of hardhat-verify `etherscan` configuration through the TENDERLY_AUTOMATIC_POPULATE_HARDHAT_VERIFY_CONFIG env variable,
// and the network is some of the Tenderly networks.
function shouldPopulateHardhatVerifyConfig(
hre: HardhatRuntimeEnvironment,
): boolean {
return (
// Must cover both since AUTOMATIC_POPULATE_HARDHAT_VERIFY_CONFIG is the legacy because we didn't use the TENDERLY_ prefix.
(process.env.TENDERLY_AUTOMATIC_POPULATE_HARDHAT_VERIFY_CONFIG === "true" ||
process.env.AUTOMATIC_POPULATE_HARDHAT_VERIFY_CONFIG === "true") &&
(isTenderlyNetworkConfig(hre.network.config) ||
isTenderlyGatewayNetworkConfig(hre.network.config)) &&
isHttpNetworkConfig(hre.network.config)
);
}

// populateHardhatVerifyConfig will populate `hre.config.etherscan` configuration of the `@nomicfoundation/hardhat-verify` plugin.
// This function should import `@nomicfoundation/hardhat-verify` type declaration expansion of the `HardhatConfig`, but can't since there will be double overloading task error if the client application also uses `@nomicfoundation/hardhat-verify` plugin.
async function populateHardhatVerifyConfig(
Expand Down