Change an array to a vector #2225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
EstherWx
force-pushed
the
uninit-mem-var
branch
3 times, most recently
from
b9c2ff3
to
4a95add
Compare
Member 'IterativeParsingReaderHandler::Logs' is not initialized in the constructor and it's hard to initialize an array in the old version of Vsiual Studio. Change it to a vector and remove the need for LogCapacity and LogCount as separate members. Move the const static variables out from the template struct 'IterativeParsingReaderHandler' to solve 'undefined reference for LOG_*' link errors.
EstherWx
force-pushed
the
uninit-mem-var
branch
from
4a95add
to
9079ce3
Compare
EstherWx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Member 'IterativeParsingReaderHandler::Logs' is not initialized in the constructor and it's hard to initialize an array in the old version of Vsiual Studio. Change it to a vector and remove the need for LogCapacity and LogCount as separate members.
Move the const static variables out from the template struct 'IterativeParsingReaderHandler' to solve 'undefined reference for LOG_*' link errors.