Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake minimum version required. #1689

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Add CMake minimum version required. #1689

merged 1 commit into from
Apr 10, 2020

Conversation

g199209
Copy link
Contributor

@g199209 g199209 commented Apr 10, 2020

Interface Libraries feature is not available before CMake 3.0

If we add find_package(RapidJSON) in CMakeLists.txt and use old cmake to build the project, the cmake progress will failed:

CMake Error at CMakeLists.txt:xx (add_library):     
  Cannot find source file:   
         INTERFACE
  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx     

This feature is only available after CMake 3.0, see this discussion for detail.

Interface Libraries feature is not available before CMake 3.0

Signed-off-by: Gao Mingfei <[email protected]>
@g199209
Copy link
Contributor Author

g199209 commented Apr 10, 2020

@tchernobog

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.739% when pulling 1ce28f4 on g199209:master into f376690 on Tencent:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.739% when pulling 1ce28f4 on g199209:master into f376690 on Tencent:master.

@miloyip miloyip merged commit 8f4c021 into Tencent:master Apr 10, 2020
@miloyip
Copy link
Collaborator

miloyip commented Apr 10, 2020

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants