Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where the PAGPlayer::presentingTime() method returns a negative value. #2635

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

CodeJhF
Copy link
Collaborator

@CodeJhF CodeJhF commented Dec 23, 2024

…ith video composition.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (6dc13b6) to head (6626824).

Files with missing lines Patch % Lines
src/rendering/PAGPlayer.cpp 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
+ Coverage   77.25%   77.27%   +0.01%     
==========================================
  Files         425      425              
  Lines       22462    22461       -1     
  Branches     6356     6356              
==========================================
+ Hits        17354    17356       +2     
- Misses       3808     3810       +2     
+ Partials     1300     1295       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domchen domchen merged commit 288343f into Tencent:main Dec 23, 2024
8 checks passed
@domchen domchen changed the title Fixed the issue of negative performance data when loading PAG files w… Fix an issue where the PAGPlayer::presentingTime() method returns a negative value. Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants