Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the heap-buffer-overflow issue by adding boundary check for the strlen() call. #2232

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

domchen
Copy link
Collaborator

@domchen domchen commented Apr 2, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 60.65%. Comparing base (4b3f0b0) to head (80bf7d3).

Files Patch % Lines
src/codec/utils/DecodeStream.cpp 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
- Coverage   60.82%   60.65%   -0.17%     
==========================================
  Files         385      385              
  Lines       22043    22042       -1     
  Branches     6402     6402              
==========================================
- Hits        13408    13370      -38     
  Misses       4672     4672              
- Partials     3963     4000      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domchen domchen merged commit 1a80d77 into main Apr 2, 2024
7 checks passed
@domchen domchen deleted the bugfix/domchen_strlen branch April 2, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants