Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when life cycle of ImageTask is longer than life cycle of file #145

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

h3r3x3
Copy link
Contributor

@h3r3x3 h3r3x3 commented Mar 3, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #145 (9e63348) into main (c54d40e) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   63.92%   64.15%   +0.23%     
==========================================
  Files         562      562              
  Lines       26652    26654       +2     
  Branches     7515     7515              
==========================================
+ Hits        17037    17101      +64     
+ Misses       4802     4798       -4     
+ Partials     4813     4755      -58     
Impacted Files Coverage Δ
...rc/gpu/opengl/GLQuadPerEdgeAAGeometryProcessor.cpp 60.86% <0.00%> (-10.87%) ⬇️
libpag/src/rendering/utils/PathUtil.cpp 72.72% <0.00%> (-4.55%) ⬇️
libpag/src/rendering/filters/FilterModifier.cpp 91.30% <0.00%> (-4.35%) ⬇️
libpag/tgfx/src/gpu/ProgramBuilder.cpp 58.01% <0.00%> (-3.06%) ⬇️
...bpag/tgfx/src/gpu/TextureMaskFragmentProcessor.cpp 58.97% <0.00%> (-2.57%) ⬇️
libpag/tgfx/src/gpu/opengl/GLUniformHandler.cpp 52.54% <0.00%> (-2.46%) ⬇️
libpag/tgfx/src/core/Data.cpp 43.39% <0.00%> (-1.89%) ⬇️
libpag/src/video/VideoSequenceDemuxer.cpp 77.41% <0.00%> (-1.62%) ⬇️
...pag/src/rendering/renderers/TrackMatteRenderer.cpp 44.00% <0.00%> (-1.34%) ⬇️
libpag/src/codec/utils/DecodeStream.cpp 57.69% <0.00%> (-1.10%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54d40e...9e63348. Read the comment docs.

@domchen domchen merged commit 6665b68 into main Mar 4, 2022
@domchen domchen deleted the bugfix/liamcli_fixImageTask branch March 4, 2022 06:02
@hanbinbin hanbinbin mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants