Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Context* instead of GLInterface* during drawing, Remove unnecessary context parameters. #143

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

domchen
Copy link
Collaborator

@domchen domchen commented Mar 2, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #143 (ccf5019) into main (8345c85) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   64.55%   64.56%           
=======================================
  Files         562      562           
  Lines       26265    26307   +42     
  Branches     7428     7440   +12     
=======================================
+ Hits        16956    16984   +28     
- Misses       4552     4555    +3     
- Partials     4757     4768   +11     
Impacted Files Coverage Δ
libpag/tgfx/src/gpu/opengl/GLContext.cpp 78.72% <0.00%> (-21.28%) ⬇️
libpag/src/video/VideoSequenceDemuxer.cpp 74.19% <0.00%> (-4.84%) ⬇️
libpag/src/video/VideoDecoder.cpp 51.06% <0.00%> (-4.26%) ⬇️
libpag/tgfx/src/gpu/opengl/GLProgram.cpp 82.14% <0.00%> (-3.58%) ⬇️
...ibpag/tgfx/src/gpu/opengl/GLProgramDataManager.cpp 87.09% <0.00%> (-3.23%) ⬇️
libpag/src/base/ByteData.cpp 54.28% <0.00%> (-2.86%) ⬇️
libpag/src/base/Transform2D.cpp 69.44% <0.00%> (-2.78%) ⬇️
libpag/tgfx/src/gpu/Device.cpp 60.52% <0.00%> (-2.64%) ⬇️
libpag/tgfx/src/core/vectors/freetype/FTMask.cpp 62.74% <0.00%> (-1.97%) ⬇️
libpag/tgfx/src/core/ImageInfo.cpp 75.92% <0.00%> (-1.86%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8345c85...ccf5019. Read the comment docs.

@lvpengwei lvpengwei merged commit be3652e into main Mar 2, 2022
@lvpengwei lvpengwei deleted the feature/domchen_context branch March 2, 2022 09:35
@hanbinbin hanbinbin mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants