Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Color with Color4f in tgfx. #106

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Replace Color with Color4f in tgfx. #106

merged 4 commits into from
Feb 14, 2022

Conversation

domchen
Copy link
Collaborator

@domchen domchen commented Feb 13, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #106 (8fb825f) into main (fffc089) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   64.15%   63.93%   -0.22%     
==========================================
  Files         541      541              
  Lines       25720    25729       +9     
  Branches     7251     7254       +3     
==========================================
- Hits        16500    16451      -49     
- Misses       4627     4634       +7     
- Partials     4593     4644      +51     
Impacted Files Coverage Δ
libpag/tgfx/src/gpu/ProgramCache.cpp 60.00% <0.00%> (-8.58%) ⬇️
libpag/tgfx/src/gpu/ColorShader.cpp 66.66% <0.00%> (-8.34%) ⬇️
...ibpag/tgfx/src/gpu/YUVTextureFragmentProcessor.cpp 73.33% <0.00%> (-6.67%) ⬇️
libpag/tgfx/src/core/PixelBuffer.cpp 58.53% <0.00%> (-4.88%) ⬇️
libpag/src/video/VideoDecoder.cpp 51.06% <0.00%> (-4.26%) ⬇️
...pag/src/rendering/renderers/TrackMatteRenderer.cpp 41.33% <0.00%> (-4.00%) ⬇️
libpag/tgfx/src/core/Data.cpp 43.39% <0.00%> (-3.78%) ⬇️
libpag/tgfx/src/core/images/webp/WebpImage.cpp 48.22% <0.00%> (-3.55%) ⬇️
libpag/src/video/SoftwareDecoderWrapper.cpp 52.58% <0.00%> (-3.45%) ⬇️
libpag/src/rendering/graphics/Recorder.cpp 58.94% <0.00%> (-3.16%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffc089...8fb825f. Read the comment docs.

@domchen domchen requested a review from lvpengwei February 14, 2022 01:17
Copy link
Collaborator

@lvpengwei lvpengwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvpengwei lvpengwei merged commit 48a8385 into main Feb 14, 2022
@lvpengwei lvpengwei deleted the feature/domchen_color branch February 14, 2022 03:42
@hanbinbin hanbinbin mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants