Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wyh dev #364

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Wyh dev #364

merged 3 commits into from
Dec 3, 2019

Conversation

CHWYH
Copy link
Collaborator

@CHWYH CHWYH commented Dec 3, 2019

Checklist:

Copy link
Collaborator

@timcui timcui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review OK

tmp.ajax &&
tmp.ajax.forEach(function(ajax, i) {
if (!ajax.SN) {
return;
}
viewData.push(ajax);
if( ajax ){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajax判空应该在 !ajax.SN之前,不然达不到判空效果

@timcui timcui merged commit d13c335 into Tencent:master Dec 3, 2019
Copy link
Collaborator

@RobinzZH RobinzZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

viewData.push(tmp.curr);
}

tmp &&
tmp.ajax &&
tmp.ajax.forEach(function(ajax, i) {
if (!ajax.SN) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajax的空判断方这里会比较好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants