-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wyh dev #364
Wyh dev #364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review OK
bin/tsw/util/auto-report/download.js
Outdated
tmp.ajax && | ||
tmp.ajax.forEach(function(ajax, i) { | ||
if (!ajax.SN) { | ||
return; | ||
} | ||
viewData.push(ajax); | ||
if( ajax ){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ajax判空应该在 !ajax.SN之前,不然达不到判空效果
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bin/tsw/util/auto-report/download.js
Outdated
viewData.push(tmp.curr); | ||
} | ||
|
||
tmp && | ||
tmp.ajax && | ||
tmp.ajax.forEach(function(ajax, i) { | ||
if (!ajax.SN) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ajax的空判断方这里会比较好
Checklist: