This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Allow plugins to reload the webview #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves on Telerik-Verified-Plugins#195 by making the same URL fixes prior to reloading the web view. Without this, a broken URL would be assigned to the webview and reloading would not work properly.
Merged
EddyVerbruggen
added a commit
that referenced
this pull request
Nov 20, 2015
Allow plugins to reload the webview
|
Looks good to me and works fine in my smoke tests. Thanks! If you even need to tweak this or other bits feel free to submit another PR and merge it as I've just added you as a collaborator. |
|
Awesome! Thanks. :) |
EddyVerbruggen
added a commit
that referenced
this pull request
Nov 20, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on #195 by making the same URL fixes prior to reloading the web view when a plugin calls
webview.loadRequest.Without this, a broken URL would be assigned to the webview and reloading would not work properly.