Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests to python 3 #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Port tests to python 3 #1

wants to merge 3 commits into from

Conversation

Arusekk
Copy link

@Arusekk Arusekk commented Oct 26, 2020

This PR is a basic port to python 3 (retaining compatibility wherever possible), tests work with twisted/twisted#1145 applied.

Please consider merging, as distros are deleting telepathy-haze only because its tests are in python 2 only.
https://bugs.gentoo.org/714636
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=938639
https://bugzilla.redhat.com/show_bug.cgi?id=1676130

@mgorny
Copy link

mgorny commented Oct 27, 2020

This PR is a basic port to python 3 (retaining compatibility wherever possible), tests work with twisted/twisted#1145 applied.

Given that this patch was rejected upstream 1.5 year ago, I don't see how that helps at all.

glib2reactor is deprecated in favor of gireactor
@Arusekk
Copy link
Author

Arusekk commented Oct 27, 2020

@mgorny fixed

@Kaffeine Kaffeine self-assigned this Oct 31, 2020
@Kaffeine
Copy link
Member

Hello.
The maintainer of the Qt parts of Telepathy is here 👋 . I noticed that this repo "Updated 4 days ago" and thus got here.

The release process in glib repositories is complicated. The most important point is that minor (0.x) versions are branched right after 0.x.0 release, so the current master is targeting for (potential) 0.10 releases.

We have to make a choice — release 0.10.0 or release some next 0.8.x version.

"Making a next patch release" sounds safer to me because there is a number of untested changes in the master branch.
according to the NEWS file, the StreamMedia support is removed from the current master branch.

On the other hand, there are some deprecation fixes in the master/0.10.0 release and I doubt that we can make the situation worse. Ideally, someone will standup as a maintainer or at least patches-upstreamer. It won't require a lot of time — even a few hours per year would be much better than nothing.

@Arusekk
Copy link
Author

Arusekk commented Nov 1, 2020

I can rebase this on a different branch, or submit another pull request, but first please let me know:
is this the upstream repo, or https://gitlab.freedesktop.org/telepathy/telepathy-haze/ is?
I submitted a merge request there, too, by the way. I am really willing to help this change get through release process, since soon there will be no libpurple support in telepathy packaged for any distro out there. And I really hoped for Sailfish OS getting it eventually.

@Kaffeine
Copy link
Member

Kaffeine commented Nov 9, 2020

Sorry for the long reply — I had no time to dive into this.
I merged this (commit from the appropriate PR) into 0.8.

Is this the time for a 0.8.1 release or there is something else to merge? (I merged the libpurple compat patch).
If no reply I'll release 0.8.1 tomorrow from the code at https://github.com/TelepathyIM/telepathy-haze/commits/telepathy-haze-0.8

After the release tagged I'll merge 0.8 to master and push the changes to gitlab.fd.o.

@Kaffeine
Copy link
Member

Kaffeine commented Nov 9, 2020

is this the upstream repo, or https://gitlab.freedesktop.org/telepathy/telepathy-haze/ is?

I had no idea those repos exist. I guess this can follow the status of other telepathy repos: I bi-directionally sync them. Feel free to propose a patch here or on fd.o (the only issue is that a reviewer is needed and I'm not the right dev for a review in glib-based code).

@Arusekk
Copy link
Author

Arusekk commented Nov 23, 2020

As for the release, it is not yet listed here: https://telepathy.freedesktop.org/components/telepathy-haze/

@Kaffeine
Copy link
Member

As for the release, it is not yet listed here: https://telepathy.freedesktop.org/components/telepathy-haze/

I had no idea that there is a list of releases. I'll update it, probably today.
TelepathyIM/telepathy-www#3

@ran-dall
Copy link

@Kaffeine Just a friendly FYI that the version and download link on telepathy.freedesktop.org/components/telepathy-haze don't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants