-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tests to python 3 #1
base: master
Are you sure you want to change the base?
Conversation
Given that this patch was rejected upstream 1.5 year ago, I don't see how that helps at all. |
glib2reactor is deprecated in favor of gireactor
@mgorny fixed |
Hello. The release process in glib repositories is complicated. The most important point is that minor ( We have to make a choice — release 0.10.0 or release some next 0.8.x version. "Making a next patch release" sounds safer to me because there is a number of untested changes in the On the other hand, there are some deprecation fixes in the master/0.10.0 release and I doubt that we can make the situation worse. Ideally, someone will standup as a maintainer or at least patches-upstreamer. It won't require a lot of time — even a few hours per year would be much better than nothing. |
I can rebase this on a different branch, or submit another pull request, but first please let me know: |
Sorry for the long reply — I had no time to dive into this. Is this the time for a 0.8.1 release or there is something else to merge? (I merged the libpurple compat patch). After the release tagged I'll merge |
I had no idea those repos exist. I guess this can follow the status of other telepathy repos: I bi-directionally sync them. Feel free to propose a patch here or on |
As for the release, it is not yet listed here: https://telepathy.freedesktop.org/components/telepathy-haze/ |
I had no idea that there is a list of releases. I'll update it, probably today. |
@Kaffeine Just a friendly FYI that the version and download link on telepathy.freedesktop.org/components/telepathy-haze don't work. |
This PR is a basic port to python 3 (retaining compatibility wherever possible), tests work with twisted/twisted#1145 applied.
Please consider merging, as distros are deleting telepathy-haze only because its tests are in python 2 only.
https://bugs.gentoo.org/714636
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=938639
https://bugzilla.redhat.com/show_bug.cgi?id=1676130