Fix build for Qt5.11+ #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix missing '}' in QScintilla's project file; - Fix error: invalid use of incomplete type 'class QAction'; - Add _build to ignore list.
|
Seems like my PR broke for both environments. I can't see the error message for the semaphoreci one, tho. About the AppVeyor, what should I do to fix it? The image seems to not have |
|
Bump. Is this repository still maintained or was it superseeded by another project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't compiling for me (ArchLinux, Qt 5.12), so I did some research on how to solve the errors I had. Seems like Qt5.11 broke some obscure things here and there.
Changes:
qmakeforQt4Qt5¹ directory);_buildto ignore list (since it's mentioned on readme in build process).¹Full path:
nclcomposer/src/plugins/ncl-textual-view/deps/QScintilla_gpl-2.10.1/Qt4Qt5.The spacing changes (trim trailling whitespaces on end of line) were done by my editor automatically on save.
This is probally my first contribution for a project that is not from a close friend, so, please check if it's all ok here, haha. :)