Pass Ignore Patterns to Hooks #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore-file patterns are based on simple bash pattern matching. Vendor exclusions are now subject to the ignore-dir logic.
|
It works perfectly! Arigatō gozaimasu! ❤️ |
…urce= directives as being relative to the script they're in.
…ttern is not file-specific and could just match a directory, causing its files/folders to be ignored. formatting: Normalized leading whitespace to tabs
docs: add 'Passing Ignore Patterns To Hooks' section refactor: modify is_path_ignored_by_dir_pattern to take a directory as the argument refactor: use case-statements for pattern matching
Owner
Author
|
@balihb Could you check this updated version and see if it still works for you? |
Owner
Author
|
@DariaKunoichi Could you take a look at this and see if it could meet your needs ? |
Owner
Author
|
@spkane could you take a look at this and see if it could meet your needs ? |
I can’t easily test this at the moment, as my original issue was raised when I was working for another organization, but the general functionality looks good and will hopefully prove useful in the future. |
TekWizely
changed the title
This was referenced Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore-file patterns are based on simple bash pattern matching.
Vendor exclusions are now subject to the ignore-dir logic.
Relates to #23, #24, #33, #37
cc: @balihb Hoping you can help me test this. I think you would add
--hook:ignore-dir=.cacheas an argument to your hook invocation.I haven't even tested myself yet so this is very alpha-level :)