Skip to content

fix(tests): wire orphaned keys.test into test suite and delete dead simulation_cache.test #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbdulmalikAlayande merged 1 commit into from
Jul 30, 2026
Merged

fix(tests): wire orphaned keys.test into test suite and delete dead simulation_cache.test #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
199 changes: 0 additions & 199 deletions src/alerts/simulation_cache.test.ts
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions src/alerts/keys.test.ts → tests/alerts/keys.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { describe, it, expect, vi, beforeEach } from "vitest";
// --- 1. CORE IMPLEMENTATION CODE ---
// ==========================================

import { KeychainStore, SecureKeypairStore, KeysCliController } from "./keys";
import { KeychainStore, SecureKeypairStore, KeysCliController } from "../../src/alerts/keys";

// ==========================================
// --- 2. TDD AUTOMATED TEST SUITE ---
Expand All @@ -14,7 +14,7 @@ describe("TDD - Local OS Keychain & Safe CLI Key Management Engine", () => {
let mockKeytar: any;
let secureStore: SecureKeypairStore;
let cliController: KeysCliController;

// In-memory fake database tracking our OS keychain simulations cleanly
let fakeKeychainDb: Array<{ account: string; value: string }>;

Expand All @@ -40,14 +40,14 @@ describe("TDD - Local OS Keychain & Safe CLI Key Management Engine", () => {
// Act
const targetLabel = "deployer-keypair";
const rawSecretSeed = "SCON3...SOROBAN...SECRET...SEED";

const saveResult = await secureStore.saveKey(targetLabel, rawSecretSeed);

// Assert: Verify internal keytar execution signals
expect(saveResult).toBe(true);
expect(mockKeytar.setPassword).toHaveBeenCalledTimes(1);
expect(mockKeytar.setPassword).toHaveBeenCalledWith("sorokeep-keys", targetLabel, rawSecretSeed);

// Confirm it exists in our simulated OS vault
expect(fakeKeychainDb[0].value).toBe(rawSecretSeed);
});
Expand All @@ -74,7 +74,7 @@ describe("TDD - Local OS Keychain & Safe CLI Key Management Engine", () => {
// Act & Assert defensive tracking boundaries
await expect(secureStore.saveKey("", "SCON123")).rejects.toThrow();
await expect(secureStore.saveKey("valid-name", "")).rejects.toThrow();

expect(mockKeytar.setPassword).not.toHaveBeenCalled();
});
});
});
Loading