Skip to content

fix: remove unused ResourceEstimate import in resource_estimate.test.ts - #537

Merged
AbdulmalikAlayande merged 1 commit into
TegoLabs:mainfrom
samuel22x:fix/remove-unused-resource-estimate-import
Jul 30, 2026
Merged

AbdulmalikAlayande merged 1 commit into
TegoLabs:mainfrom
samuel22x:fix/remove-unused-resource-estimate-import

Conversation

@samuel22x

Copy link
Copy Markdown
Contributor

What does this PR do?

Why?

Does this touch secret-key handling or transaction submission?

  • Yes — see notes above
  • No

Checklist

  • Tests pass (npm test)
  • Type check passes (npx tsc --noEmit)
  • Lint passes (npm run lint)
  • Tests cover the new functionality (TDD preferred — see CONTRIBUTING.md)
  • No unnecessary dependencies added
  • Commit messages follow conventional format
  • No console.log in core logic
  • ADR added if this is a significant design decision (see docs/adr)
  • E2E sandbox tested, if this touches RPC or daemon behavior (see docs/e2e-sandbox.md)

closes #367

@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@samuel22x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 34cd145b-5c8c-4fff-b57a-fd4a32cb9e8f

📥 Commits

Reviewing files that changed from the base of the PR and between 35d9237 and 46d7d7d.

📒 Files selected for processing (1)
  • tests/rpc/resource_estimate.test.ts
📜 Recent review details
🔇 Additional comments (1)
tests/rpc/resource_estimate.test.ts (1)

19-19: LGTM!


📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated test imports without changing test behavior or coverage.

Walkthrough

The resource estimate test import was simplified to remove the unused ResourceEstimate type while retaining parseResourceEstimate. Test logic remains unchanged.

Changes

Resource estimate test cleanup

Layer / File(s) Summary
Test import cleanup
tests/rpc/resource_estimate.test.ts
The test file now imports only parseResourceEstimate from the RPC client module.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: abdulmalikalayande

Poem

A bunny trims an import line,
One unused type hops away,
The parser stays, the tests remain,
Clean lint greets the day.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing an unused ResourceEstimate import from the test file.
Description check ✅ Passed The description is related to the change and references the linked issue, even though it uses a template.
Linked Issues check ✅ Passed The change matches issue #367 by removing the unused import and leaving the test logic unchanged.
Out of Scope Changes check ✅ Passed Only the requested import cleanup was made, with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitguardian

gitguardian Bot commented Jul 29, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret ded54f4 tests/commands/guard-cli-export-import.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@AbdulmalikAlayande
AbdulmalikAlayande merged commit 88558a0 into TegoLabs:main Jul 30, 2026
3 of 5 checks passed
AbdulmalikAlayande pushed a commit that referenced this pull request Aug 2, 2026
…e.test.ts (#537)

Verified locally: lint, typecheck, full suite (1039/1039), build, and audit all clean. Closes #367.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(tests): remove unused ResourceEstimate import flagged by lint in tests/rpc/resource_estimate.test.ts

2 participants