[IMP] 15.0: generate flanker cached tables during build #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems OK for me at first. @yajo WDTY? |
ap-wtioit
force-pushed
the
master-fix_flanker_for_15_0
branch
from
0351551
to
833fd29
Compare
pedrobaeza
approved these changes
Mar 9, 2022
yajo
reviewed
Mar 9, 2022
There was a problem hiding this comment.
@ap-wtioit can you please paste the start of the logs when you start odoo with this image? Just to make sure it fixes the problem at runtime.
15.0.Dockerfile
Outdated
| @@ -139,6 +139,9 @@ RUN build_deps=" \ | |||
| watchdog \ | |||
| wdb \ | |||
| && (python3 -m compileall -q /usr/local/lib/python3.8/ || true) \ | |||
| # generate flanker cached tables during install when /usr/local/lib/ is still intended to be written to | |||
| # https://github.com/Tecnativa/doodba/issues/486 | |||
| && python3 -c 'from flanker.addresslib import address' >/dev/null \ | |||
There was a problem hiding this comment.
That last part is trying to silent the warnings? If so, it's not working.
Try:
Suggested change
| && python3 -c 'from flanker.addresslib import address' >/dev/null \ | |
| && python3 -c 'from flanker.addresslib import address' 2> /dev/null \ |
There was a problem hiding this comment.
thanks for checking, will test locally and push a fixed commit
my initial test search was wrong (searching for flanker package names)
this should be avoided:
#17 218.2 Symbol 'mailbox_or_url_list' is unreachable
#17 218.2 Symbol 'delim' is unreachable
#17 218.2 Symbol 'mailbox_or_url' is unreachable
#17 218.2 Symbol 'url' is unreachable
#17 218.2 Symbol 'mailbox_or_url_list' is unreachable
#17 218.2 Symbol 'delim' is unreachable
#17 218.2 Symbol 'mailbox_or_url' is unreachable
#17 218.2 Symbol 'mailbox' is unreachable
#17 218.2 Symbol 'url' is unreachable
#17 218.2 Symbol 'angle_addr' is unreachable
#17 218.2 Symbol 'name_addr' is unreachable
#17 218.2 Symbol 'phrase' is unreachable
#17 218.2 Symbol 'mailbox_or_url_list' is unreachable
#17 218.2 Symbol 'delim' is unreachable
#17 218.2 Symbol 'mailbox_or_url' is unreachable
#17 218.2 Symbol 'mailbox' is unreachable
#17 218.2 Symbol 'addr_spec' is unreachable
#17 218.2 Symbol 'angle_addr' is unreachable
#17 218.2 Symbol 'name_addr' is unreachable
#17 218.2 Symbol 'phrase' is unreachable
#17 218.2 Symbol 'local_part' is unreachable
#17 218.2 Symbol 'domain' is unreachable
#17 218.2 Symbol 'quoted_string' is unreachable
#17 218.2 Symbol 'domain_literal' is unreachable
#17 218.2 Symbol 'quoted_string_text' is unreachable
#17 218.2 Symbol 'domain_literal_text' is unreachable
#17 218.2 Symbol 'mailbox_or_url_list' is unreachable
#17 218.2 Symbol 'delim' is unreachable
There was a problem hiding this comment.
using python3 -c 'from flanker.addresslib import address' >/dev/null 2>&1 to disregard all stdout and stderr from the import statement
Logs for |
yajo
approved these changes
Mar 9, 2022
and ignore the warnings printed on the first import see mailgun/flanker#231
ap-wtioit
force-pushed
the
master-fix_flanker_for_15_0
branch
from
833fd29
to
d81a424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #486