Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eventonica] Revise Part 7 - React #1472

Closed
wants to merge 0 commits into from
Closed

[Eventonica] Revise Part 7 - React #1472

wants to merge 0 commits into from

Conversation

vegetabill
Copy link
Collaborator

Resolves #1421

@vegetabill vegetabill changed the title [Eventonica] Revise (and reorder) Part 3 - React [Eventonica] Revise Part 3 - React Feb 13, 2021
Copy link
Collaborator

@alodahl alodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm just concerned about the class name, and about the re-render comment at the end. Re-rendering on state change is like the main point of React.

projects/eventonica/eventonica-part7-react.md Outdated Show resolved Hide resolved
projects/eventonica/eventonica-part7-react.md Outdated Show resolved Hide resolved
@vegetabill
Copy link
Collaborator Author

Thanks for reviewing! Since I have a little cushion of time on this, going to prioritize cleaning up the whole Eventonica mess and will come back to this in a week or so.

@vegetabill vegetabill changed the title [Eventonica] Revise Part 3 - React [Eventonica] Revise Part 7 - React Feb 27, 2021
@vegetabill vegetabill closed this Mar 1, 2021
@vegetabill
Copy link
Collaborator Author

vegetabill commented Mar 1, 2021

@alodahl oof I did something dumb with git and now it thinks this is closed but it was never merged to main.

The real changes are now in #1505 including all your suggested revisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Eventonica] Update React portion
2 participants