Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported Poetry version to be 1.5.0 #27

Closed
d-ryan-ashcraft opened this issue Jun 9, 2023 · 3 comments
Closed

Update minimum supported Poetry version to be 1.5.0 #27

d-ryan-ashcraft opened this issue Jun 9, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@d-ryan-ashcraft
Copy link
Contributor

d-ryan-ashcraft commented Jun 9, 2023

When using -SNAPSHOT replacement added in 2.6.0 in a managed dependency, the following issue is encountered from Poetry 1.2.0 through 1.4.2. One we hit 1.5.0 or higher, it works. This tracks with the Poetry release notes, where issue poetry-core #402 is fixed in 1.5.0.

In this example, module-x 1.1.0.dev987654321 exists in the configured [[tool.poetry.source]] options within pyproject.toml.

[INFO] --- habushu-maven-plugin:2.6.0:install-dependencies (default-install-dependencies) @ sample-python-module ---
[INFO] Locking dependencies specified in pyproject.toml...
[INFO] Executing Poetry command: poetry lock
[INFO] Updating dependencies
[INFO] Resolving dependencies...
[ERROR] 
Because sample-python-module depends on module-x (1.1.0.*) which doesn't match any versions, version solving failed.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
@d-ryan-ashcraft
Copy link
Contributor Author

d-ryan-ashcraft commented Jun 9, 2023

🧱 A workaround exists - update your Python to at least 1.5.0 and things will work without issue in Habushu 2.6.0. For instance, you can run the following command: poetry self update 2.5.1.

@d-ryan-ashcraft d-ryan-ashcraft self-assigned this Jun 9, 2023
@d-ryan-ashcraft d-ryan-ashcraft added the bug Something isn't working label Jun 9, 2023
@d-ryan-ashcraft d-ryan-ashcraft added this to the 2.6.1 milestone Jun 9, 2023
d-ryan-ashcraft added a commit that referenced this issue Jun 9, 2023
@d-ryan-ashcraft
Copy link
Contributor Author

UPDATE - once ready, we should remove the shim added to support Poetry < 1.5.0: https://github.com/TechnologyBrewery/habushu/pull/35/files?diff=unified&w=1

@d-ryan-ashcraft d-ryan-ashcraft removed this from the 2.6.1 milestone Aug 22, 2023
@d-ryan-ashcraft d-ryan-ashcraft added this to the 2.7.1 milestone Sep 7, 2023
d-ryan-ashcraft added a commit that referenced this issue Sep 7, 2023
d-ryan-ashcraft added a commit that referenced this issue Sep 7, 2023
d-ryan-ashcraft added a commit that referenced this issue Sep 7, 2023
…y-version

#27 🐛 Update minimum Poetry version from 1.2.0 to 1.5.0 to better…
@d-ryan-ashcraft
Copy link
Contributor Author

CI build passed:
image

@d-ryan-ashcraft d-ryan-ashcraft changed the title Wildcard managed dependencies don't work below 1.5.0 Update minimum supported Poetry version to be 1.5.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant