[ReactPHP] Handle uncaught errors by sending their error message as response back #9538
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanhey
suggested changes
Jan 16, 2025
| @@ -38,7 +39,9 @@ function requestHandler(): Closure | |||
| '/update' => updateraw(queryCount($request), $world, $update), | |||
| // '/info' => info(), | |||
| default => new Response(404, [], 'Error 404'), | |||
| }; | |||
| }))->catch( | |||
| static fn (Throwable $error): PromiseInterface => resolve(Response::plaintext($error->getMessage())->withStatus(200)), // This should be a 500, but with a 200 the benchmarking tooling considers the framework alive | |||
There was a problem hiding this comment.
It's OK to send a 500 response to the tests.
The problem is in React or the code. The app is blocked again when send a 500.
I said it to fix the root of the problem.
You can check it with the plain PHP files, and send a 500 error, the tests will continue normally and the tests fail.
There was a problem hiding this comment.
Also update your local repo, because my PR is included now, and the db tests are disabled.
So never will arrive to this catch().
So this PR need to include again the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.