Upgrade aiohttp

[Dreamsorcerer]

No description provided.

[Dreamsorcerer]

Database credentials don't work anymore? I haven't touched those in the PR..

[Dreamsorcerer]

@NateBrady23 or anyone know what to change for the DB credentials? Would be good to get this upgrade in as there's been a lot of performance optimisations in recent releases (though they may be a magnitude more noticeable in real world scenarios than these simple benchmarks).

[volyrique]

Could it be an issue with the authentication method (issue #8061 might be related)?

[Dreamsorcerer]

Could it be an issue with the authentication method (issue #8061 might be related)?

I'm unclear. We just create a DSN with user/password, so I don't see anything we'd need to change for that:

FrameworkBenchmarks/frameworks/Python/aiohttp/app/main.py

Line 32 in 1beae77

password=os.getenv('PGPASS', 'benchmarkdbpass'),

Appears that asyncpg implemented the auth method 6 years ago, so I doubt it's an issue there either..

[volyrique]

Yes, but the point is that the password is not necessarily sent in cleartext to the server - see here. asyncpg might not be using the correct method (the defaults have changed much more recently than 6 years ago, as the issue I linked to demonstrates, and some methods might have been removed - other frameworks have been broken by database updates), hence failing with an authentication error. The error message doesn't seem to go into that kind of details, so I would probably run a packet capture to see what is happening on the wire, unless asyncpg provides that information somehow (I am not familiar with it).

Just an idea, since you were asking for suggestions.