Skip to content

Conversation

@idlewan
Copy link
Contributor

@idlewan idlewan commented Jul 3, 2014

Redis is a fast in-memory database.
While it won't be applicable to huge databases that don't fit in memory, having redis tests is still quite useful to determine if its use can add or substract performance compared to a postgresql or mysql setup with prepared queries.

@idlewan
Copy link
Contributor Author

idlewan commented Jul 15, 2014

Rebased on #902 to be able to very cleanly select either the redis or postgresql database backend while reusing all the common code.

@aschneider-techempower
Copy link
Contributor

I have a feeling that there's some issue with configuration somewhere.

Output Error.

While you are at it, please rebase on master.

@idlewan
Copy link
Contributor Author

idlewan commented Jul 21, 2014

Rebased on master.

I'm guessing that redis wasn't running, I put in a fix.

@aschneider-techempower
Copy link
Contributor

Error and Output

I've checked the redis connectivity with redis-cli and it appears to have information in there, so that's not the issue.

@idlewan
Copy link
Contributor Author

idlewan commented Jul 21, 2014

The error (Error: unhandled exception: Connection refused [EOS]) is the program quitting right after startup because it can't connect to redis.
Maybe the database hostname isn't replaced right. Could you please post the beginning of the file model_redis.nim (I'm interested in the db = open(...) line), that should have been modified after the replace_text in setup_redis.py has run?

@aschneider-techempower
Copy link
Contributor

You're right

I fixed the host manually and it appears that you failed the fortunes test.

You can check out the requirements here

We can merge it as is if you like, with fortunes commented out, or you can fix the fortunes and update the PR (also fix the string substitution if possible)

@idlewan
Copy link
Contributor Author

idlewan commented Jul 21, 2014

That should do it.

aschneider-techempower added a commit that referenced this pull request Jul 22, 2014
Add redis database and nawak-redis test
@aschneider-techempower aschneider-techempower merged commit 4e7dbf8 into TechEmpower:master Jul 22, 2014
@idlewan idlewan deleted the redis branch October 31, 2014 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants