[toolset] Fix results.json contains only result of last test.

[methane]

When I run tests, there is only one result in results.json.
It was because benchmarker makes child process and results updated in child process.

[hamiltont]

Just experienced this issue and I can confirm that using these commits fixed the problem. My test results now show up in both results.json files

[hamiltont]

For what it's worth, this line creates potential to experience UnboundLocalVariable, which I just experienced by trying to add log.debug("Before load %s" % str(results)). Not sure if there's a way to ensure this doesn't happen to anyone else?

[hamiltont]

Perhaps you could use a local variable named something other than results?

[hamiltont]

Ok, so my python knowledge isn't deep. I could easily fix this by using self.results instead of trying to print the results variable. However, it may still be useful to rename that local variable just to avoid any future problems

[methane]

else: clause of try: statement will be executed only when try: block finished without any exception.
But it's not easy to understand for person from other languages.

[hamiltont]

There is nothing wrong with the logic here, I'm saying that perhaps it's not a good choice to have a variable self.results and a variable results, they are easily confused. Perhaps rename results