Adding support for Martini & Goji frameworks - Go

[agrison]

Adding benchmark support for Martini & Goji, two web frameworks for Go.

See:

• http://martini.codegangsta.io
• https://github.com/go-martini/martini
• https://github.com/zenazn/goji
• https://goji.io

[martin-g]

does Fatalf() exit the process automatically ?
I haven't used Go so just wondering why you'd let it continue after this fatal error

[agrison]

log.Fatalf logs then exit with error code 1.
See: http://golang.org/pkg/log/#Fatalf

[martin-g]

👍

[bhauer]

@agrison Thanks for this contribution! We will aim to have this merged in for Round 10.

[methane]

When shell=True, command passed to subprocess.call should be str, not list.
So .rsplit(" ") should removed.

[methane]

subprocess.call() waits command finished.
Use Popen instead.

[aschneider-techempower]

env=env throws an exception

[hamiltont]

@agrison In addition to alex's comment on env=env, I'll add that it's useless here. Your entire environment is persisted into the subprocess by default, including that snazzy GOPATH update above ;-) Please remove env=env from all of these subprocess lines

[aschneider-techempower]

After correcting the env=env thing, a few of the tests still fail. Goji

For Martini, it seems to want the user to log into github. Please fix that.

[hamiltont]

Per some changes in #915, please remove this line. Add a new file at goji/bash_profile.sh, and inside it put the line export GOPATH=$TROOT

here's an example bash_profile.sh for the go framework

[hamiltont]

@agrison Awesome to see a few more go tests! If you will rebase this onto our master branch, and then update the .travis.yml file to add lines for Martini & Goji, Travis-CI will verify that your additions work properly and can be merged

A number of the comments here are minor changes. If you would like a working example, please consult the latest go directory as it works perfectly at the moment

[agrison]

@hamiltont I've rebased my branch onto master but the travis build is not working, I don't know why but it keeps trying to update something on the linux box and fail because the apt-get is waiting for input on :

Configuration file `/etc/rsyslog.conf'
 ==> Modified (by you or by a script) since installation.
 ==> Package distributor has shipped an updated version.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
 The default action is to keep your current version.
*** rsyslog.conf (Y/I/N/O/D/Z) [default=N] ? 

Then it gets stuck and won't continue. I can't see any difference with the other Go frameworks. Any advice ?

Example: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/35114986

Sorry for the delay I was not able to find some time to work on that lately and was in vacation all the summer.

[hamiltont]

I think you can add -o Dpkg::Options::="--force-confdef" -o
Dpkg::Options::="--force-confold" to your apt command to automatically make
a selection here.

Head's up - I'm going to have very little presence here for the next month
or two, so ping the TE team if you need help

On Fri, Sep 12, 2014 at 9:26 AM, Alexandre Grison [email protected]
wrote:

@hamiltont https://github.com/hamiltont I've rebased my branch onto
master but the travis build is not working, I don't know why but it keeps
trying to update something on the linux box and failed because the apt-get
is waiting for input on :

Configuration file `/etc/rsyslog.conf'
==> Modified (by you or by a script) since installation.
==> Package distributor has shipped an updated version.
What would you like to do about it ? Your options are:
Y or I : install the package maintainer's version
N or O : keep your currently-installed version
D : show the differences between the versions
Z : start a shell to examine the situation
The default action is to keep your current version.
*** rsyslog.conf (Y/I/N/O/D/Z) [default=N] ?

Then it gets staled and won't continue. I can't see any difference with
the other Go frameworks. Any advice ?

Example:
https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/35114986

Sorry for the delay I was not able to find some time to work on that
lately and was in vacation all the summer.

—
Reply to this email directly or view it on GitHub
#837 (comment)
.

[agrison]

Ok thanks @hamiltont , I think I'll check about that, the problem is that the apt-get commands are being issued automatically, it seems I don't have control about that.

[hamiltont]

I've restarted the last travis build as this rsyslog stuff should be fixed in master

[hamiltont]

Ping @agrison - the restarted travis build has finished. Looks like there are a few remaining issues with goji, and there's something causing the start method of your setup.py for martini to hang forever

[msmith-techempower]

@agrison There were SOOOO many changes to the suite in the last few weeks - I would prefer a rebase from master to give Travis another chance.

[LadyMozzarella]

Closing because another implementation of Goji has been added to TFB and the Martini framework is no longer available on Github.