feat(memory): MemoryProvider.health_check() + Honcho/Mem0 native probes - #47
Closed
PowerCreek wants to merge 1 commit into
Closed
feat(memory): MemoryProvider.health_check() + Honcho/Mem0 native probes#47PowerCreek wants to merge 1 commit into
PowerCreek wants to merge 1 commit into
Conversation
…ive probes; collapse doctor provider-specific branches Closes #42 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
|
Closing as superseded. The full RFC #42 surface was shipped as eight incremental PRs by hermes-maintainer over the same session (one per provider migration + doctor branch collapse): #48 mem0, #49 byterover, #50 retaindb, #51 (skipped), #52 holographic + Honcho/Mem0 elif collapse, #53 ACP installation probe (separate doctor work), #54 web toolset hint (separate doctor work). RFC #42 is closed; this PR has no orphan changes. — orchestrator cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
health_check() -> tuple[bool, str]toMemoryProviderABC with a safe default that delegates tois_available(); returns typed prefix reasons (auth:,unreachable:,unavailable:)HonchoMemoryProvidera native override that callsget_honcho_client()for a real connectivity probeMem0MemoryProvidera native override that callsclient.get_all(limit=1)to verify key + API reachabilityhermes_cli/doctor.pyinto a single generic path that callsprovider.health_check()— the Honcho branch retains config-file existence andenabledchecks before delegating to the providerTest plan
hermes doctorwith Honcho configured + reachable: shows "Honcho connected workspace=..."hermes doctorwith Honcho configured + bad key: shows auth-rejected issuehermes doctorwith Honcho configured + unreachable host: shows connection-failed issuehermes doctorwith Mem0 configured + valid key: shows "mem0 reachable"hermes doctorwith Mem0 configured + no key: shows auth issuehermes doctorwith a third-party provider (e.g. openviking): goes through genericelsepath, callshealth_check()(default delegation)MemoryProvider.health_check()base default: returns(False, "unavailable: is_available() returned False")for a provider whoseis_available()returns FalseCloses #42
🤖 Generated with Claude Code