Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract and expose webhook handler logic as http.Handler #9

Merged
merged 1 commit into from
May 26, 2020
Merged

Extract and expose webhook handler logic as http.Handler #9

merged 1 commit into from
May 26, 2020

Conversation

jrdnull
Copy link
Contributor

@jrdnull jrdnull commented May 26, 2020

  • Extracted logic for handling webhook to WebhookHandler to allow easier reuse
  • Set Content-Type on challenge request to avoid rendering HTML

@jrdnull
Extract and expose webhook handler logic as http.Handler
637f783 
- Extracted logic for handling webhook to WebhookHandler to allow easier reuse
- Set Content-Type on challenge request to avoid rendering HTML
toffentoffen
toffentoffen approved these changes May 26, 2020
View reviewed changes
Copy link

@toffentoffen toffentoffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrdnull jrdnull merged commit d662f16 into master May 26, 2020
@jrdnull jrdnull deleted the webhooks branch May 26, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toffentoffen toffentoffen toffentoffen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrdnull @toffentoffen