Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(github): updates PR template to close issue linked to PR #291

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

esparr
Copy link
Collaborator

@esparr esparr commented Nov 19, 2023

Pull Request Template

1. Targeted Issue

This PR fixes #290

2. Overview of Solution

In a Github PR, when you have the word fixes before the linked issue, when the PR is merged, the issue is automatically closed. This PR updated the github PR template to include this language so it is used by developers.

3. Tools Used

Github PR Template

Here are all the words that can be used to close a PR in this way:

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

4. Testing Strategy

None, will use this PR as the test to see if it closes the linked issue.

5. Future Implications

Great for more automation of tasks!

6. Screenshots

7. Code Reviewers

@GitLukeW @nzeager

@esparr esparr requested a review from GitLukeW November 19, 2023 00:12
Copy link

netlify bot commented Nov 19, 2023

Deploy Preview for staging-momentors ready!

Name Link
🔨 Latest commit 3c5fb7f
🔍 Latest deploy log https://app.netlify.com/sites/staging-momentors/deploys/655952dbd058ea0008a55088
😎 Deploy Preview https://deploy-preview-291--staging-momentors.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@esparr esparr requested a review from nzeager November 19, 2023 00:12
Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@GitLukeW GitLukeW merged commit 545e2bb into staging Nov 20, 2023
5 checks passed
@GitLukeW GitLukeW deleted the docs/issue-290/pr-template-fe branch November 20, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a developer I want a PR being merged to close the linked issue (FE)
2 participants