Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#118 views folder #135

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

Laura-D-Andrews
Copy link
Contributor

Pull Request Template

1. Targeted Issue

Ticket #118

2. Overview of Solution

Created a views directory and file for each view class in that directory

3. Tools Used

Insomnia for endpoint testing, flake8 for debugging

4. Testing Strategy

I tested all the endpoints locally on Insomnia

5. Future Implications

None anticipated

6. Screenshots

N/a

7. Code Reviewers


Before you go...

  • I have linked the relevant issue
  • I have provided an overview of my solution
  • I have shared the tools I've used
  • I have outlined my testing strategy
  • I have considered future implications of my changes
  • I have included relevant screenshots
  • I have kept my team in the loop

Big high-fives for your incredible pull request! We're thrilled to have you as a contributor! Our team will dig into your proposed changes and give you some feedback or merge them if they're good to go. Your contributions mean the world to us!

@esparr esparr self-requested a review September 7, 2023 21:27
Copy link
Collaborator

@esparr esparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, everything looks good.

I found an issue with archive sessions but reviewing your code, it was not introduced with this change. I created a new ticket to address the bug.

This is good to go 🚀

@esparr esparr merged commit 11dc426 into TeamProductionSystem:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants