Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds flake8 config file and cleans up linting #133

Merged
merged 7 commits into from
Sep 8, 2023

Conversation

esparr
Copy link
Collaborator

@esparr esparr commented Sep 6, 2023

Pull Request Template

1. Targeted Issue

Add flake8 config file to remove unnecessary linting errors when running flake8

Ticket #128

2. Overview of Solution

  • Adds .flake8 file to project to hold universal flake8 configurations.
  • Removes redundant files for models.py, serializers.py and views.py
  • Cleans up all lingering linting errors

3. Tools Used

flake8 configuration file
https://flake8.pycqa.org/en/latest/user/configuration.html

4. Testing Strategy

Ran flake8 in terminal
Saw it removed files in .flake8 config file so they are not linted

5. Future Implications

This lets us not have to visually ignore linting errors that do not need fixing. Devs can focus on what actually needs to be fixed.

6. Screenshots

Before:
Screen Shot 2023-09-06 at 7 00 03 PM

After removing unnecessary files:
Screen Shot 2023-09-06 at 7 00 21 PM

After fixing lingering linting errors:
Screen Shot 2023-09-06 at 6 59 30 PM

7. Code Reviewers

@GitLukeW @Laura-D-Andrews


Before you go...

  • I have linked the relevant issue
  • I have provided an overview of my solution
  • I have shared the tools I've used
  • I have outlined my testing strategy
  • I have considered future implications of my changes
  • I have included relevant screenshots
  • I have kept my team in the loop

@esparr esparr changed the title chore: add flake8 config file and cleans up linting chore: adds flake8 config file and cleans up linting Sep 6, 2023
@esparr esparr marked this pull request as ready for review September 7, 2023 22:54
Copy link
Contributor

@GitLukeW GitLukeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and past test. Thank you again for the contribution!

Approved and Merged!

@GitLukeW GitLukeW merged commit c935078 into TeamProductionSystem:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants