Conversation
|
|
||
| ## Downloader improvements | ||
|
|
||
| [@kapadomy](https://github.com/kapadomy) continued his awesome work on the downloader. in this release he calculated an estimated remaining downlaod time which is shown on the download panel. To improve support of more external audio players, audio which is encoded as OPUS is now saved as OGG in a .webem file. In case you needed to pause a download (or some network interruption forced you to do so), NewPipe can now recover the expired download links and resume it after a long time. In case there should be an error while downloading an audio or video, the app now displays more debug info helping to track the cause down. |
There was a problem hiding this comment.
| [@kapadomy](https://github.com/kapadomy) continued his awesome work on the downloader. in this release he calculated an estimated remaining downlaod time which is shown on the download panel. To improve support of more external audio players, audio which is encoded as OPUS is now saved as OGG in a .webem file. In case you needed to pause a download (or some network interruption forced you to do so), NewPipe can now recover the expired download links and resume it after a long time. In case there should be an error while downloading an audio or video, the app now displays more debug info helping to track the cause down. | |
| [@kapadomy](https://github.com/kapadomy) continued his awesome work on the downloader. in this release he calculated an estimated remaining download time which is shown on the download panel. To improve support of more external audio players, audio which is encoded as OPUS is now saved as OGG instead of a .webm file. In case you needed to pause a download (or some network interruption forced you to do so), NewPipe can now recover the expired download links and resume it after a long time. In case there should be an error while downloading an audio or video, the app now displays more debug info helping to track the cause down. |
There was a problem hiding this comment.
it's hard to see in the diff but there are 2 typos in there
There was a problem hiding this comment.
Spotted em, it's instead of and webem -> webm. I think .webm should even be escaped.
There was a problem hiding this comment.
| [@kapadomy](https://github.com/kapadomy) continued his awesome work on the downloader. in this release he calculated an estimated remaining downlaod time which is shown on the download panel. To improve support of more external audio players, audio which is encoded as OPUS is now saved as OGG in a .webem file. In case you needed to pause a download (or some network interruption forced you to do so), NewPipe can now recover the expired download links and resume it after a long time. In case there should be an error while downloading an audio or video, the app now displays more debug info helping to track the cause down. | |
| [@kapadomy](https://github.com/kapadomy) continued his awesome work on the downloader. in this release he calculated an estimated remaining download time which is shown on the download panel. To improve support of more external audio players, audio which is encoded as Opus is now saved in a `.ogg` file instead of a `.webm` file. In case you needed to pause a download (or some network interruption forced you to do so), NewPipe can now recover the expired download links and resume it after a long time. In case there should be an error while downloading an audio or video, the app now displays more debug info helping to track the cause down. |
I added escaping to the file extension and and fixed the format names (it's Opus and .ogg now (the latter refers to the container in the file only, it's not like any conversion would take place), not OPUS and OGG; I might be a little pedantic there).
There was a problem hiding this comment.
I took a closer at the PR. We switched from downloading Opus audio as .opus to .webm, but it is planed to switch to .ogg in a later PR. That's why I'd remove that line as the change will only be effective for short time.
Co-Authored-By: cool-student <43842960+cool-student@users.noreply.github.com>
TheAssassin
left a comment
There was a problem hiding this comment.
I skimmed the text, looks good to me.
|
Thanks for the review @cool-student and @TheAssassin :) |
|
Please notify me then, I'll publish the website then. |
Jekyll received an update to version 4.0 which decreases the build time significantly. However that update contains some changes which are not compatible with the 3.8 version. I think the site is too small and not frequently build to justify a time-consuming migration. That's why I only update from version 3.8.5 to 3.8.6.
Most importantly, here is a draft of the release post for version 0.18.0. The post is not finished yet, but here is what I wrote down on a train ride lately. Two screenshots are missing, I'll add them later this week.