Skip to content

[YouTube] Add uploaderUrl and uploaderVerified to PlaylistInfoItem. #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TobiGr merged 2 commits into from
Oct 31, 2022
Merged

[YouTube] Add uploaderUrl and uploaderVerified to PlaylistInfoItem. #959

TobiGr merged 2 commits into from
Oct 31, 2022

Conversation

@FireMasterK
Copy link
Member

@FireMasterK FireMasterK commented Oct 29, 2022

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Note: There are no tests for this anywhere, so I haven't added any

@FireMasterK FireMasterK force-pushed the playlist-info-item-uploader branch from 8f32399 to 7d87ca6 Compare October 29, 2022 21:45
@FireMasterK FireMasterK changed the title Add uploaderUrl and verified to PlaylistInfoItem. Add uploaderUrl and uploaderVerified to PlaylistInfoItem. Oct 29, 2022
@FireMasterK FireMasterK force-pushed the playlist-info-item-uploader branch 3 times, most recently from a3f7046 to 8aeba78 Compare October 29, 2022 22:01
@FireMasterK FireMasterK marked this pull request as draft October 29, 2022 22:11
@FireMasterK FireMasterK force-pushed the playlist-info-item-uploader branch from 8aeba78 to 8ed5764 Compare October 29, 2022 22:21
@FireMasterK FireMasterK marked this pull request as ready for review October 29, 2022 22:21
@FireMasterK FireMasterK force-pushed the playlist-info-item-uploader branch from 8ed5764 to 6a256d0 Compare October 30, 2022 13:00
TobiGr
TobiGr reviewed Oct 30, 2022
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just a minor note.
What about the other services?

@TobiGr TobiGr added enhancement New feature or request youtube service, https://www.youtube.com/ multiservice Issues related to multiple services labels Oct 30, 2022
@FireMasterK
Copy link
Member Author

FireMasterK commented Oct 30, 2022

What about the other services?

I don't have the time or patience to implement them, sorry. I implemented this for Piped (where this PR is already deployed), where YouTube is the only used service.

@TobiGr TobiGr merged commit eb40bb8 into TeamNewPipe:dev Oct 31, 2022
@TobiGr TobiGr mentioned this pull request Oct 31, 2022
Closed
@TobiGr TobiGr changed the title Add uploaderUrl and uploaderVerified to PlaylistInfoItem. [YouTube] Add uploaderUrl and uploaderVerified to PlaylistInfoItem. Oct 31, 2022
This was referenced Nov 4, 2022
Merged
Closed
@FireMasterK FireMasterK deleted the playlist-info-item-uploader branch June 2, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request multiservice Issues related to multiple services youtube service, https://www.youtube.com/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FireMasterK @TobiGr